Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Package and usage to 1.2.0 #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bump Package and usage to 1.2.0 #24

wants to merge 2 commits into from

Conversation

JonnavithulaGirish
Copy link
Member

Related Issues

Change log

  • Transcend Core Config now accepts default consent and tcString that can be set from customers backend using config.setDefaultConsent and config.setDefaultTCString methods.

@height Height
Copy link

height bot commented Jun 28, 2024

This pull request has been linked to and will mark 1 task as "Pending Deploy" when merged:

💡Tip: You can link multiple Height tasks to a pull request.

@JonnavithulaGirish JonnavithulaGirish requested a review from a team June 28, 2024 08:14
anotherminh
anotherminh reviewed Jun 28, 2024
View reviewed changes
app/src/main/res/layout/activity_main.xml
android:layout_width="match_parent"
android:layout_height="match_parent"
android:visibility="gone"/>
<!-- <io.transcend.webview.TranscendWebView-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why comment out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the component initialization to be on a dialog, since most customers use it. But kept this code, if anyone wants to refer.

anotherminh
anotherminh approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@anotherminh anotherminh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anotherminh anotherminh anotherminh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonnavithulaGirish @anotherminh