Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #136

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Update dependencies #136

merged 1 commit into from
Feb 28, 2024

Conversation

dmattia
Copy link
Member

@dmattia dmattia commented Feb 27, 2024

@dmattia
Copy link
Member Author

dmattia commented Feb 27, 2024

@eligrey Are the tests here sufficient to merge if they all pass?

@eligrey
Copy link
Member

eligrey commented Feb 27, 2024

afaik this should be fine

eligrey
eligrey approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@eligrey eligrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dmattia dmattia merged commit 10b7742 into main Feb 28, 2024
10 checks passed
@delete-merged-branch delete-merged-branch bot deleted the dmattia/dependabot branch February 28, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfarrell76 michaelfarrell76 michaelfarrell76 approved these changes

@eligrey eligrey eligrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmattia @eligrey @michaelfarrell76