feat(ingest/snowflake): allow iceberg tables in lineage and access me…

…tadata (datahub-project#10961)
trafi · Aug 22, 2024 · 88b3893 · 88b3893
1 parent 0927c63
commit 88b3893
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/metadata-ingestion/src/datahub/ingestion/source/snowflake/constants.py b/metadata-ingestion/src/datahub/ingestion/source/snowflake/constants.py
@@ -52,6 +52,7 @@ class SnowflakeObjectDomain(str, Enum):
     DATABASE = "database"
     SCHEMA = "schema"
     COLUMN = "column"
+    ICEBERG_TABLE = "iceberg table"
 
 
 GENERIC_PERMISSION_ERROR_KEY = "permission-error"

diff --git a/metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_query.py b/metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_query.py
@@ -35,6 +35,7 @@ class SnowflakeQuery:
         SnowflakeObjectDomain.EXTERNAL_TABLE.capitalize(),
         SnowflakeObjectDomain.VIEW.capitalize(),
         SnowflakeObjectDomain.MATERIALIZED_VIEW.capitalize(),
+        SnowflakeObjectDomain.ICEBERG_TABLE.capitalize(),
     }
 
     ACCESS_HISTORY_TABLE_VIEW_DOMAINS_FILTER = "({})".format(

diff --git a/metadata-ingestion/tests/integration/snowflake/common.py b/metadata-ingestion/tests/integration/snowflake/common.py
@@ -156,7 +156,7 @@
                 on basic_usage_counts.bucket_start_time = user_usage_counts.bucket_start_time
                 and basic_usage_counts.object_name = user_usage_counts.object_name
         where
-            basic_usage_counts.object_domain in ('Table','External table','View','Materialized view')
+            basic_usage_counts.object_domain in ('Table','External table','View','Materialized view','Iceberg table')
             and basic_usage_counts.object_name is not null
         group by
             basic_usage_counts.object_name,