-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Chart)!: 📦 add separated chart for CRDs #1223
base: master
Are you sure you want to change the base?
Conversation
bd35651
to
b674cf7
Compare
9087b4b
to
e1eb8a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The CI needs to be tested, with a tag on your fork.
- The documented CRDs upgrade process should still work. I see (at least) two options:
a. Keep and copy crd files
b. Update CRD upgrade instruction to use them in the new directory
e9619df
to
6a67459
Compare
Tested on my own account as seen with you 👍 |
I'm not strongly against option 1, but I think we will clearly lost users on the way. The approach of having a dependency chart seduced me at first because of managing all this compatibility complexity being a responsibility delegated to us. The other option is keeping it that way:
However, even with the option 1, the main points remains how users can migrate from the previous system to the new one ? Adding the annotation works but the command I provided is mainly linux friendly :-) |
It might be worth checking out how https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack is setup. It bundles https://github.com/prometheus-community/helm-charts/tree/main/charts/prometheus-operator-crds in but has an option to not install them for when you want to manage them separately. I’ve been using that lately and it works well and isn’t too difficult. |
Co-authored-by: Michel Loiseleur <[email protected]>
Co-authored-by: Michel Loiseleur <[email protected]>
efe6901
to
9855fc9
Compare
What does this PR do?
This PR introduces a separate chart used by the main one to install CRDs.
The dependency between the main chart and the CRDs one will be added once CRDs one will be released.
Motivation
#1141
#1209
More
make test
and all the tests passed