-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IR Refactor Part 2: Reflection, Semantic Categories #442
Merged
+2,370
−2,004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxtremblay
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did my best to review this one, but many changes are beyond my knowledge of cubecl. Hope this review is still useful
maxtremblay
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing a very error prone conversion in the optimizer, adds new macros to automatically generate reflection info for all IR operations.
They allow decomposing the typed operation into an
OpCode
and aVec<Variable>
(only if all arguments areVariable
,None
is returned otherwise). Also allows reconstructing the typed represenation from the opcode and argument list, where applicable. Generating these conversion makes it safer and reduces the amount of code that needs to be manually added to the optimizer when adding new operations.Also adds additional information about things like side effects and commutativity directly to operations, making it less error prone.
Additionally, introduces three new semantic categories to
Operation
:Arithmetic
,Comparison
andBitwise
. This allows breaking the monolithicOperator
enum into more manageable categories.Testing
All tests pass