Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline API for Cuda #422

Merged
merged 12 commits into from
Jan 17, 2025
Merged

Pipeline API for Cuda #422

merged 12 commits into from
Jan 17, 2025

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented Jan 14, 2025 •
edited
Loading

Addition of the Cuda Pipeline API (see Cuda example) for async memory copy. It should be used in matmul pipelined.

nathanielsimard
nathanielsimard approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only thing to do before merging is to fix the docs and maybe add a bit more.

crates/cubecl-core/src/frontend/context.rs Outdated
@@ -100,6 +100,13 @@ impl CubeContext {
matrix
}

/// Create a new matrix element.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong doc

@nathanielsimard nathanielsimard merged commit 23690b9 into main Jan 17, 2025
5 checks passed
@nathanielsimard nathanielsimard deleted the feat/cuda/pipeline2 branch January 17, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielsimard nathanielsimard nathanielsimard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louisfd @nathanielsimard