Flush when too many handles are locked #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielsimard
force-pushed
the
fix/wgpu/memory-lock
branch
from
c19aa0e to
665443b
Compare
maxtremblay
approved these changes
Jan 13, 2025
| } | ||
|
|
||
| impl MemoryLock { | ||
| /// Create a new memory lock with the given flushing threshold. | ||
| pub fn new(flush_threshold: usize) -> Self { |
There was a problem hiding this comment.
Should rename the function to with_threshold?
There was a problem hiding this comment.
I don't think so, there is no other way to create it, you need a threshold to create the memory lock.
Comment on lines
26
to
30
| pub fn should_flush(&self) -> bool { | ||
| // For now we only consider the number of handles locked, but we may consider the amount in | ||
| // bytes at some point. | ||
| self.locked.len() >= self.flush_threshold | ||
| } |
There was a problem hiding this comment.
Regarding its usage, I suggest renaming to has_reach_threshold. At least, when use in WgpuStream, we don't flush the memory lock. The current name suggests that after this function returns true, we should flush the memory lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It helps when running wgpu tests or with autotune when tensors are allocated, but the kernel is never executed.