Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for numeric constants. #112

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Add support for numeric constants. #112

merged 1 commit into from
Sep 14, 2024

Conversation

booti386
Copy link
Contributor

No description provided.

@booti386 booti386 force-pushed the constants branch 2 times, most recently from d849275 to ecec006 Compare September 10, 2024 14:36
@nathanielsimard
Copy link
Member

Can we add some tests to validate for each float type?

@booti386
Copy link
Contributor Author

Can we add some tests to validate for each float type?

Yes. Also fixed my crappy impl.

@booti386 booti386 force-pushed the constants branch 2 times, most recently from 5376bd7 to f536c42 Compare September 12, 2024 06:37
@booti386
Copy link
Contributor Author

Minor changes to allow cargo fmt to parse and format the custom macro syntax.

@nathanielsimard nathanielsimard merged commit 4d517c3 into tracel-ai:main Sep 14, 2024
2 of 5 checks passed
@booti386 booti386 deleted the constants branch September 14, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielsimard nathanielsimard nathanielsimard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booti386 @nathanielsimard