Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is AFAIK the first time an implementation turns values of a vectorization factor X to an output of vectorization factor 1. This will be useful for many more functions like .mean(), so I first want to make this pull request before I start making a multitude of new functions.
The way I implemented it is through a new expand function called
fixed_output_unary_expand
with following signature:It works identical to
unary_expand
but it can take in a different output item, could be a different vectorization, could also be a different type, from the input. In principal this function is strictly more general thanunary_expand
, so perhapsunary_expand
should just turn into this function. We can use the same concept to implement new binary functions like dot which also have a different vectorization factor for the output.