Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

アクセスのない Runtime App を自動で落とせるようにする #965

Merged
merged 24 commits into from
Nov 18, 2024
Merged

アクセスのない Runtime App を自動で落とせるようにする #965

merged 24 commits into from
Nov 18, 2024

Conversation

pirosiki197
Copy link
Contributor

@pirosiki197 pirosiki197 commented Oct 10, 2024 •
edited
Loading

なぜやるか

ref #961
今のところ k8s にのみ対応。dockerはまだなので、別PRで実装します。

やったこと

  • local-manifestにsablierを追加
  • ユーザーから自動シャットダウンを設定された Runtime App が sablier middleware を使うように変更
  • Dashboard で今回の設定ができるように

.local-manifestでmake upすると動作確認できます。

やらなかったこと

backend が docker の方は実装がまだです。

資料

@github-actions GitHub Actions
Copy link

Preview (prod backend + PR dashboard) → https://965.ns-preview.trapti.tech/

@pirosiki197 pirosiki197 changed the title Feat/auto shutdown アクセスのない Runtime App を自動で落とせるようにする Oct 10, 2024
motoki317
motoki317 reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@motoki317 motoki317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker backendの実装はしないのかな？

pkg/infrastructure/backend/k8simpl/list_containers.go Outdated Show resolved Hide resolved
pkg/infrastructure/backend/k8simpl/backend.go Outdated Show resolved Hide resolved
pkg/domain/backend.go Outdated Show resolved Hide resolved
@pirosiki197
Copy link
Contributor Author

docker backendの方もこの後実装するつもりです
k8sで動くようにする -> dashboard -> docker の順に実装していこうと考えてます

@pirosiki197 pirosiki197 marked this pull request as ready for review October 26, 2024 05:10
motoki317
motoki317 reviewed Nov 5, 2024
View reviewed changes
migrations/schema.sql Outdated Show resolved Hide resolved
cp-20
cp-20 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@cp-20 cp-20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼ dashboard しか見てないけど良さそうです:+1:

cp-20
cp-20 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@cp-20 cp-20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

バックエンドの方も含めて見ました　良さそうです！　dashboardの方がconflictしてるのでそこだけサッと直してもらえると:pray:

@pirosiki197 pirosiki197 merged commit 0bdfcca into main Nov 18, 2024
19 checks passed
@pirosiki197 pirosiki197 deleted the feat/auto-shutdown branch November 18, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motoki317 motoki317 motoki317 left review comments

@cp-20 cp-20 cp-20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pirosiki197 @motoki317 @cp-20