[TASK] Remove ignoreErrors settings, closes #164

tpwd · Jan 3, 2025 · ffb3552 · ffb3552
1 parent b70d80c
commit ffb3552
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 14 deletions.
diff --git a/Classes/Indexer/IndexerBase.php b/Classes/Indexer/IndexerBase.php
@@ -269,7 +269,6 @@ public function addTagsToRecords($uids, $pageWhere = '')
                 ->add('select', $fields)
                 ->from('pages')
                 ->from('tx_kesearch_filteroptions')
-                // @phpstan-ignore-next-line
                 ->add('where', $where)
                 ->groupBy('pages.uid')
                 ->executeQuery();

diff --git a/Classes/Lib/Db.php b/Classes/Lib/Db.php
@@ -121,18 +121,14 @@ public function getSearchResultByMySQL()
             $resultQuery = $queryBuilder
                 ->add('select', $queryParts['SELECT'])
                 ->from($queryParts['FROM'])
-                // @phpstan-ignore-next-line
                 ->add('where', $queryParts['WHERE']);
             if (!empty($queryParts['GROUPBY'])) {
-                // @phpstan-ignore-next-line
                 $resultQuery->add('groupBy', $queryParts['GROUPBY']);
             }
             if (!empty($queryParts['ORDERBY'])) {
-                // @phpstan-ignore-next-line
                 $resultQuery->add('orderBy', $queryParts['ORDERBY']);
             }
             if (!empty($queryParts['HAVING'])) {
-                // @phpstan-ignore-next-line
                 $resultQuery->add('having', $queryParts['HAVING']);
             }
         } else {
@@ -572,8 +568,6 @@ public function getWhere()
             // @extensionScannerIgnoreLine
             $where .= $pageRepository->enableFields($this->table);
         } else {
-            // phpstan-ignore-next-line can be removed once support for TYPO3 12 is dropped
-            // @phpstan-ignore-next-line
             $constraints = $pageRepository->getDefaultConstraints($this->table);
             $expressionBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
                 ->getQueryBuilderForTable($this->table)

diff --git a/Tests/phpstan.neon b/Tests/phpstan.neon
@@ -4,12 +4,5 @@ parameters:
 		- ../Classes
 		- ../Configuration
 		- ../Tests
-	reportUnmatchedIgnoredErrors: false
 	ignoreErrors:
 		- '#has unknown class Tpwd\\KeSearchPremium\\KeSearchPremium as its type\.#'
-		- '#PHPDoc tag @var for variable \$moduleData contains unknown class TYPO3\\CMS\\Backend\\Module\\ModuleData\.#'
-		- '#Call to method get\(\) on an unknown class TYPO3\\CMS\\Backend\\Module\\ModuleData\.#'
-		- '#Call to an undefined method TYPO3\\CMS\\Backend\\Template\\ModuleTemplate::assign\(\)\.#'
-		- '#Call to an undefined method TYPO3\\CMS\\Backend\\Template\\ModuleTemplate::renderResponse\(\)\.#'
-		- '#Class TYPO3\\CMS\\Backend\\View\\BackendViewFactory not found\.#'
-		- '#Access to constant ERROR on an unknown class TYPO3\\CMS\\Core\\Type\\ContextualFeedbackSeverity\.#'