Skip to content

Commit

Permalink
Updating editorconfig
Browse files Browse the repository at this point in the history
  • Loading branch information
tpill90 committed May 26, 2024
1 parent 474b0e8 commit f715323
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
9 changes: 8 additions & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,15 @@ dotnet_style_prefer_collection_expression = false
# IDE0090 : 'new' expression can be simplified
csharp_style_implicit_object_creation_when_type_is_apparent = false

# IDE0290: Use primary constructor
# - I'm a fan of this syntax in Typescript, but it still feels a bit too jarring seeing it C# now
csharp_style_prefer_primary_constructors = true


# Banned APIs will be bumped up to an error instead of warning
dotnet_diagnostic.rs0030.severity = error

# The method does not need to use async/await - Introduces annoying 'return' statements for async methods, that hurt code readability.
dotnet_diagnostic.AsyncFixer01.severity = none
dotnet_diagnostic.AsyncFixer01.severity = none


2 changes: 1 addition & 1 deletion BattleNetPrefill/Properties/launchSettings.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
},
"Prefill Test Products - No Download": {
"commandName": "Project",
"commandLineArgs": "prefill -p s1 s2 pro wow wow_classic --no-download --force"
"commandLineArgs": "prefill -p s1 s2 pro wow wow_classic --no-download --force --verbose"
},
"Prefill All - No Download - No Cache": {
"commandName": "Project",
Expand Down
1 change: 0 additions & 1 deletion BattleNetPrefill/Web/CdnRequestManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ public sealed class CdnRequestManager : IDisposable
/// </summary>
private string _productBasePath;

//TODO why is this a dictionary of requests?
private readonly List<Request> _queuedRequests = new List<Request>();

#region Debugging
Expand Down

0 comments on commit f715323

Please sign in to comment.