Skip to content

Commit

Permalink
Slight rename of a method. Adding a check to publish release to make …
Browse files Browse the repository at this point in the history
…sure a leading 'v' isn't added to the version
  • Loading branch information
tpill90 committed Aug 22, 2024
1 parent 11d7a70 commit 4558979
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions BattleNetPrefill/Web/CdnRequestManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -194,12 +194,12 @@ public async Task<byte[]> GetRequestAsBytesAsync(RootFolder rootPath, MD5Hash ha
Request request = new Request(_productBasePath, rootPath, hash, startBytes, endBytes, isIndex);
return await AppConfig.RetryPolicy.ExecuteAsync(async () =>
{
return await GetRequestAsBytesAsync(request);
return await GetRequestAsBytes_SingleRequestAsync(request);
});
}

//TODO not a fan of how many times forceRecache is passed down
private async Task<byte[]> GetRequestAsBytesAsync(Request request, bool forceRecache = false)
private async Task<byte[]> GetRequestAsBytes_SingleRequestAsync(Request request, bool forceRecache = false)
{
allRequestsMade.Add(request);

Expand Down
4 changes: 4 additions & 0 deletions _publish-release.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ Write-Color "Current version: ", $currentVersion -Color White, Yellow

# Getting new version to use
$newVersion = Read-Host "Enter new version, with no leading 'v'. Ex. '1.2.3'"
if($newVersion.Contains("v"))
{
Write-Color $newVersion, " is not a valid version since it has a leading 'v'." -Color Yellow, Red
}

# Updating csproj version
$currentContent = Get-Content -Path .\BattleNetPrefill\BattleNetPrefill.csproj -Raw
Expand Down

0 comments on commit 4558979

Please sign in to comment.