Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse-app(base)-url returns .s url or not #18

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

parse-app(base)-url returns .s url or not #18

wants to merge 6 commits into from

Commits on Feb 10, 2020

  1. add ->base-url and ->app-url (url generator)

    @saitouena
    saitouena committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    c046184 View commit details
    Browse the repository at this point in the history

  2. add ->base-url and ->app-url test

    @saitouena
    saitouena committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    dea5062 View commit details
    Browse the repository at this point in the history

  3. add ->base-url ->app-url document

    @saitouena
    saitouena committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    2266cce View commit details
    Browse the repository at this point in the history

  4. add TODO of parse-base-url and parse-app-url for consistency 

    It seems better that parse-app-url and parse-base-url return :s? key for consistency
    @saitouena
    saitouena committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    c57f664 View commit details
    Browse the repository at this point in the history

  5. parse-app-url and parse-base-url returns :s? 

    :s? is true with https://hoge.s.cybozu.com
    @saitouena
    saitouena committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    0655533 View commit details
    Browse the repository at this point in the history

  6. fix .s test

    @saitouena
    saitouena committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    fe44630 View commit details
    Browse the repository at this point in the history