-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tagsCollection object holding a display & url safe tag label #34
Conversation
I just realized that the README would need to be updated, as well. |
I think your |
One more thought on this: it occurred to me that using the same layout partial to display all tags from the global I don't think it's pretty but it works. I think that aligning the two |
So this works for me as a non-major change bump, which is nice. I feel like it'd be possible to achieve this via something like Can you update the Also if you want to add a follow-on PR after this that is a breaking change, wherein we remove Thanks! |
@hswolff I've updated the README. I'll submit another PR, soon, with the more robust API (for next major release). Thanks! |
Awesome, thank you! Merged and published as |
There are times when I want to display a list of tags that link to their respective index. Currently, the
tags
andtagsUrlSafe
arrays are separate. ThistagsCollection
array allows us to do something like the following:Rather than commit a breaking change I figured it made sense to just add an additional property to the metadata.