chore(@toss/date): use relational operators to compare dates #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gunhoflash is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for your contribution! While it is true that dates can be compared with relational operators, it is because dates are implicitly converted numbers before they are being compared. Personally, I prefer to use more explicit functions to compare dates; this is why we are using functions from date-fns. Closing the pull request for this reason. But we appreciate your pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use relational operators to compare dates.
From issue #463
PR Checklist