refactor: Refactor decorator wrapping logic #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
WhiteKiwi
commented
Nov 4, 2023
WhiteKiwi
commented
- Cache Key Strategy Change: Shifted cache key from method name to metadata.
- Decorator Logic Refactoring.
- Dependencies Update: Upgraded to TypeScript 5.0 and updated other dependencies to their latest versions.
sok125
previously approved these changes
Nov 6, 2023
sok125
reviewed
Nov 6, 2023
| const { originalFn, metadata, aopSymbol } = aopMetadata; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-this-alias | ||
| const self = this; |
sok125
reviewed
Nov 6, 2023
src/auto-aspect-executor.ts
Outdated
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-this-alias | ||
| const self = this; | ||
| function wrappedFunction(this: object, ...args: unknown[]) { |
There was a problem hiding this comment.
이름이 왜 wrappedFunction 이에용?
오히려 wrap 이렇게 하는게 낫지않나 ?
There was a problem hiding this comment.
아 구두 논의 완료.
Function이라는 키워드가 생각보다 직관적이지 않은것 같기도 해서 고민이네요.
saehun
reviewed
Nov 6, 2023
src/auto-aspect-executor.ts
Outdated
| } | ||
|
|
||
| target[aopSymbol] ??= {}; | ||
| target[aopSymbol][methodName] = wrappedFunction; |
There was a problem hiding this comment.
If we don't use Proxy, name of the method will be wrappedFunction and it affects stack and make it hard to debug.
sok125
reviewed
Nov 6, 2023
src/auto-aspect-executor.ts
Outdated
| }) { | ||
| const { originalFn, metadata, aopSymbol } = aopMetadata; | ||
|
|
||
| const proxy = new Proxy(originalFn, { |
There was a problem hiding this comment.
프록시를 사용하려고 했던 이유에 대한 테스트 작성 가능하실까요?
프록시를 뺐다가, 다시 넣은 이유에 대해서 확인이 필요해보여요.
There was a problem hiding this comment.
The function that we tried to protect using Proxy, we already have code to protect in "createDecoder". And there are related tests.
WhiteKiwi
force-pushed
the
refactor/wrap
branch
from
c2a2ad0 to
50a1733
Compare
saehun
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.