feat(compat): Add lastIndexOf function to es-toolkit/compat
#856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
raon0211
force-pushed
the
feat/lastIndexOf
branch
from
aa9ee47 to
e6567fc
Compare
raon0211
previously approved these changes
Dec 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
==========================================
- Coverage 99.64% 99.61% -0.04%
==========================================
Files 317 318 +1
Lines 2826 2838 +12
Branches 842 848 +6
==========================================
+ Hits 2816 2827 +11
- Misses 10 11 +1 |
raon0211
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
lastIndexOffunction toes-toolkit/compat. #91This function similarly to
Array.prototype.lastIndexOfbut includes support forNaNhandling, aligning its behavior with Lodash's implementation.The implementation has been tested using the test cases from the Lodash repository's
lastIndexOf. However, in the context ofes-toolkit/compat, thefromIndexparameter only acceptsnumberorundefinedtypes.As a result, test cases related to falsy values for fromIndex have been omitted.
Benchmark
Test with an array of length 1,000,000.
Coverage
These test cases were written with reference to the test cases of Lodash's lastIndexOf function.
and Instanbul's coverage report says all green.