Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(difference): Add missing readonly to parameter #83

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

mass2527
Copy link
Contributor

@mass2527 mass2527 commented Jun 26, 2024

I guess that when supporting read-only arrays, the readonly keyword was mistakenly omitted from the difference parameter.

@mass2527 mass2527 requested a review from raon0211 as a code owner June 26, 2024 14:30
Copy link

vercel bot commented Jun 26, 2024

@mass2527 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@1b3d9be). Learn more about missing BASE report.
Report is 374 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main       #83   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        51           
  Lines           ?       264           
  Branches        ?        30           
========================================
  Hits            ?       264           
  Misses          ?         0           
  Partials        ?         0           

Copy link

codspeed-hq bot commented Jun 26, 2024

CodSpeed Performance Report

Merging #83 will degrade performances by 83.01%

Comparing mass2527:fix/difference (4e14949) with main (1b3d9be)

Summary

⚡ 7 improvements
❌ 5 regressions
✅ 74 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main mass2527:fix/difference Change
lodash/difference 56.8 µs 334.4 µs -83.01%
lodash/differenceWith 385.2 µs 349.2 µs +10.32%
es-toolkit/intersection 7.2 ms 2.8 ms ×2.6
lodash/intersectionWith 246.6 µs 92.3 µs ×2.7
lodash/pick 379.4 µs 252 µs +50.55%
lodash/shuffle 319.7 µs 43.1 µs ×7.4
lodash/union 76.3 µs 232.5 µs -67.19%
lodash/unionBy 230.1 µs 75.7 µs ×3
lodash/unionWith 238.8 µs 369.6 µs -35.39%
lodash/uniqBy 21.5 ms 17.7 ms +21.22%
lodash/zip 246.6 µs 378.2 µs -34.79%
lodash/zipWith 260.1 µs 377.6 µs -31.11%

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raon0211 raon0211 merged commit cc6b4ac into toss:main Jun 27, 2024
7 of 9 checks passed
@mass2527 mass2527 deleted the fix/difference branch June 27, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants