chore(*): add codspeed for benchmark visualization #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 51 51
Lines 262 262
Branches 29 29
=========================================
Hits 262 262 |
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
manudeli
previously approved these changes
Jun 17, 2024
raon0211
reviewed
Jun 17, 2024
benchmarks/partition.bench.ts
Outdated
| @@ -3,11 +3,11 @@ import { partition as partitionToolkit } from 'es-toolkit'; | |||
| import { partition as partitionLodash } from 'lodash'; | |||
|
|
|||
| describe('partition', () => { | |||
| bench('es-toolkit', () => { | |||
| bench('es-toolkit/', () => { | |||
There was a problem hiding this comment.
🦅👀 I fixed it. Thanks! 3020b5d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #57
Background
Recently, contributions to improve the performance of the es-toolkit have been ongoing. Many people have been measuring performance improvements using the experimental bench feature applied to vitest. (like this)
So I have discovered codspeed, a tool that further automates this process, and I want to install it. We can easliy install this package because we already have
*.bench.tsfiles. Prisma is already using it, and it is available for free in public open source projects.Features
CodSpeed visualizes performance metrics, allowing us to see improvements or regressions by comparing with previous benchmarks. We can view these visualizations both in PR comments and on the codSpeed dashboard. (maybe it would be https://codspeed.io/toss/es-toolkit/benchmarks)
Changes
When I tested it in the forked repository, and it was difficult to identify which function belonged to lodash and es-toolkit. So, I added delimiters like
lodash/uniqandes-toolkit/uniqin the*.bench.tsfile.