Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(intersection): optimize intersection #47

Merged
merged 3 commits into from
Jun 14, 2024
Merged

perf(intersection): optimize intersection #47

merged 3 commits into from
Jun 14, 2024

Conversation

WooWan
Copy link
Contributor

@WooWan WooWan commented Jun 13, 2024

Optimized the intersection function by using a Set for improved lookup efficiency.

  • Size of array: 10000
Screenshot 2024-06-14 at 12 04 11 AM

Copy link

vercel bot commented Jun 13, 2024

@WooWan is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

raon0211
raon0211 previously approved these changes Jun 14, 2024
Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/array/intersection.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.54%. Comparing base (a707c06) to head (cbcede6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          46       46           
  Lines         220      221    +1     
  Branches       21       21           
=======================================
+ Hits          219      220    +1     
  Misses          1        1           

@raon0211 raon0211 merged commit 576b136 into toss:main Jun 14, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants