Eliza/moar ci #315
Merged
Eliza/moar ci #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `rustup show` commands run on CI don't actually show the real toolchain that will be used, because they run *before* we actually check out the repo. Because we haven't checked out the repo, the `rust-toolchain.toml` file...isn't there, so we don't have a configured toolchain. This commit fixes that. We now run `rustup show` *after* checking out the repo, so the `rustup show` command shows the toolchain that CI will actually use.
This is already specified in the toolchain file, so it needn't be manually installed on CI.
|
okay, so now CI both shows and downloads the actual correct Rust toolchains: https://github.com/tosc-rs/mnemos/actions/runs/8634305118/job/23669422262?pr=315#step:4:39 |
hawkw
added a commit
that referenced
this pull request
Apr 10, 2024
Currently, the `rustup show` commands run on CI don't actually show the real toolchain that will be used, because they run *before* we actually check out the repo. Because we haven't checked out the repo, the `rust-toolchain.toml` file...isn't there, so we don't have a configured toolchain. This commit fixes that. We now run `rustup show` *after* checking out the repo, so the `rustup show` command shows the toolchain that CI will actually use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.