Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul core Tracker: extract IoC Container #1188

Conversation

josecelano
Copy link
Member

Overhaul core Tracker: extract IoC Container

@josecelano josecelano self-assigned this Jan 17, 2025
@josecelano josecelano added Code Cleanup / Refactoring Tidying and Making Neat - Developer - Torrust Improvement Experience labels Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 94.36620% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.25%. Comparing base (5b46cea) to head (20018ab).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
src/console/profiling.rs 0.00% 2 Missing ⚠️
src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1188      +/-   ##
===========================================
+ Coverage    77.18%   77.25%   +0.06%     
===========================================
  Files          181      182       +1     
  Lines        12393    12424      +31     
  Branches     12393    12424      +31     
===========================================
+ Hits          9566     9598      +32     
  Misses        2659     2659              
+ Partials       168      167       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano force-pushed the 1187-overhaul-core-tracker-extract-ioc-container branch from 3e99189 to 3d0f4f8 Compare January 17, 2025 17:55
@josecelano josecelano requested a review from da2ce7 January 17, 2025 17:55
@josecelano josecelano marked this pull request as ready for review January 17, 2025 17:55
@josecelano josecelano linked an issue Jan 17, 2025 that may be closed by this pull request
@josecelano
Copy link
Member Author

ACK 20018ab

@josecelano josecelano merged commit 765bd6f into torrust:develop Jan 17, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overhaul core Tracker: extract IoC Container
1 participant