Make device-required tests independent of tests that don't use a device #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests that require a device use data created by previous tests that do not require one. This causes problems when only running device-required tests via the 'requires-device' BATS tag, as the necessary data wouldn't be created in this case. This commit makes these two types of tests independent of one another. Signed-off-by: Lucas Akira Morishita <[email protected]>
|
I noticed the pipeline on Gitlab instance passed on AVAL jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests that require a device use data created by previous tests that do not require one. This causes problems when only running device-required tests via the 'requires-device' BATS tag, as the necessary data wouldn't be created in this case.
This commit makes these two types of tests independent of one another.
The AVAL-related pipeline only run tests that require a device, so this PR fixes test errors caused by the problem described above.
Signed-off-by: Lucas Akira Morishita [email protected]