Fix 'images download' test when device has Torizon OS 7 installed #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before checking if the downloaded image tarfile has the expected ownership, the test assumes the filename starts with 'torizon-core', which is no longer the case with Torizon OS 7 images, which dropped the 'core' part of the name. This caused the test to fail as it cannot find the image with this assumption. To solve this the logic to get the tarfile name was changed as suggested by the TODO comment: the test now obtains the filename from the program output. Signed-off-by: Lucas Akira Morishita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before checking if the downloaded image tarfile has the expected ownership, the test assumes the filename starts with 'torizon-core', which is no longer the case with Torizon OS 7 images, which dropped the 'core' part of the name. This caused the test to fail as it cannot find the image with this assumption.
To solve this the logic to get the tarfile name was changed as suggested by the TODO comment: the test now obtains the filename from the program output.
Signed-off-by: Lucas Akira Morishita [email protected]