Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registryops: Fix --login-to arg behavior when using default registry #25

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

lucas-akira
Copy link
Collaborator

Until now when using the --login-to arg to login to a private container registry, if the specified registry is equal to the default one (in this case registry-1.docker.io), then the login credentials end up not being applied, resulting in a 'not authorized' error message.

Related-to: TCB-477

Signed-off-by: Lucas Akira Morishita [email protected]

Copy link
Contributor

@jsrc27 jsrc27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Until now when using the --login-to arg to login to a private container
registry, if the specified registry is equal to the default one (in this
case registry-1.docker.io), then the login credentials end up not being
applied, resulting in a 'not authorized' error message.

Signed-off-by: Lucas Akira Morishita <[email protected]>
@jsrc27 jsrc27 merged commit 6edcba9 into torizon:bullseye Aug 16, 2024
7 checks passed
@lucas-akira lucas-akira deleted the TCB-477 branch August 16, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants