build: Add support for JSON configuration files #17
Conversation
Adding support also to JSON configuration files. This way users and other programs can easily read and write the configuration file. JSON is a widely used format and has support in many programming languages and tools sometimes even natively, not the case of YAML. Signed-off-by: Matheus Castello <[email protected]>
microhobby
force-pushed
the
castello/json
branch
from
3ab92b2 to
072e265
Compare
| if config_path.endswith(".json"): | ||
| config = _load_config_file_json(config_path) | ||
| elif config_path.endswith(".yaml") or config_path.endswith(".yml"): | ||
| config = _load_config_file_yaml(config_path) |
There was a problem hiding this comment.
This should probably provide a clean error message (and abort) if no supported extension was found. Now I think it will raise an exception for config being undefined.
| error_exc = ParseError(getattr(ex, "msg", "parsing error")) | ||
| error_exc.set_source(file=config_path) | ||
| if hasattr(ex, "doc"): | ||
| error_exc.set_source(line=ex.doc) |
There was a problem hiding this comment.
Why does this use ex.doc as the line number? Seems that JSONDecodeError has lineno (and also colno) attributes: https://docs.python.org/3/library/json.html#json.JSONDecodeError
There was a problem hiding this comment.
Just a passerby here, but I noticed this PR and it looks interesting. I took a quick look, overall looks good, but I left some small comments inline. This probably also needs some documentation/example and tests, but docs probably live elsewhere and how to run (and write) tests is not really documented AFAICS, so that might be up to Toradex to add.
Adding support also to JSON configuration files. This way users and other programs can easily read and write the configuration file. JSON is a widely used format and has support in many programming languages and tools sometimes even natively, not the case of YAML.