Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image_type_torizon: improve warning for non-versioned layers #207

Conversation

griloHBG
Copy link

Currently, the warning for non-versioned layers involved in a build is not much helpful:

WARNING: Failed to get layers information. Exception: <class 'bb.process.ExecutionError'>

With this commit, the message will point which layer is causing it and what is the specific error that happened. E.g.:

WARNING: Failed to get layers information. Caused by layer at /workdir/torizon-7/layers/meta-iotedge-torizon. Exception: Execution of 'export PSEUDO_UNLOAD=1; git rev-parse HEAD' failed with exit code 128:
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Currently, the warning for non-versioned layers involved in a build is
not much helpful:

```
WARNING: Failed to get layers information. Exception: <class 'bb.process.ExecutionError'>
```

With this commit, the message will point which layer is causing it and
what is the specific error that happened. E.g.:

```
WARNING: Failed to get layers information. Caused by layer at /workdir/torizon-7/layers/meta-iotedge-torizon. Exception: Execution of 'export PSEUDO_UNLOAD=1; git rev-parse HEAD' failed with exit code 128:
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
```

Signed-off-by: Henrique Garcia <[email protected]>
@leograba
Copy link
Member

Hey @EdTheBearded can you review this contribution?

Copy link
Collaborator

@jsrc27 jsrc27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@EdTheBearded EdTheBearded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's wait until the release is finished to merge this PR.

@EdTheBearded EdTheBearded merged commit d9e7415 into torizon:scarthgap-7.x.y Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants