Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make get_client_root_url overridable both in both mixins #59

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Make get_client_root_url overridable both in both mixins #59

merged 3 commits into from
Feb 23, 2024

Conversation

zerolab
Copy link
Member

@zerolab zerolab commented Feb 15, 2024 •
edited
Loading

To-Do:

  • tests (a simple page inheriting from both mixins)
  • upgrade considerations for release notes

@zerolab zerolab marked this pull request as draft February 15, 2024 18:58
@zerolab zerolab force-pushed the feat/overridable-client-url branch 2 times, most recently from b043588 to 48a6132 Compare February 15, 2024 19:37
@zerolab zerolab force-pushed the feat/overridable-client-url branch from 48a6132 to 9f28de7 Compare February 15, 2024 22:11
@zerolab zerolab force-pushed the feat/overridable-client-url branch from 9f28de7 to 06bb4c3 Compare February 23, 2024 15:11
@zerolab zerolab marked this pull request as ready for review February 23, 2024 15:11
@zerolab zerolab merged commit 9601050 into main Feb 23, 2024
8 checks passed
@zerolab zerolab deleted the feat/overridable-client-url branch February 23, 2024 15:22
@marcoacierno marcoacierno mentioned this pull request Mar 17, 2024
Merged
@thibaudcolas thibaudcolas mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jams2 jams2 jams2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zerolab @jams2