Improve efficiency of yarn-install's registry overrride step #373
+27,920
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2f22afd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ascrazy
force-pushed
the
yarn-install-registry-overrride-in-one-pass
branch
from
29e6af9 to
e2b2be4
Compare
ascrazy
force-pushed
the
yarn-install-registry-overrride-in-one-pass
branch
5 times, most recently
from
9c9a4cf to
7b4d437
Compare
denieler
approved these changes
Jan 10, 2025
pudek357
reviewed
Jan 13, 2025
ascrazy
force-pushed
the
yarn-install-registry-overrride-in-one-pass
branch
from
7b4d437 to
2f22afd
Compare
pudek357
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Working with yarn-install I have noticed it's registry override step is quite complex and is not as fast as it could be, so I just asked an LLM to rewrite script to do the same thing but in one pass over yarn.lock and got a working solution that's also kind of more straightforward
Here's performance comparison of existing and new implementation on yarn.lock taken from toptal/client-portal:
How to test
Development checks
PR commands
List of available commands:
@toptal-anvil ping reviewers- Ping teams for review