Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVX-3180] Use GSM Secrets from actions repo #249

Closed
wants to merge 1 commit into from

Conversation

AlexDavidoiu
Copy link

@AlexDavidoiu AlexDavidoiu commented Dec 1, 2023

DEVX-3180

Description

Since davinci's gsm-secrets is the same as https://github.com/toptal/actions/blob/main/gsm-secrets/action.yml, we will use the one from actions repo as source of truth.

How to test

  • CI

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping FX team for review

Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: b445ed3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AlexDavidoiu AlexDavidoiu marked this pull request as ready for review December 1, 2023 13:46
@AlexDavidoiu AlexDavidoiu requested a review from a team December 1, 2023 13:46
@AlexDavidoiu
Copy link
Author

@toptal-anvil ping reviewers

@AlexDavidoiu AlexDavidoiu self-assigned this Dec 1, 2023
@sashuk
Copy link
Collaborator

sashuk commented Dec 1, 2023

@AlexDavidoiu Is it fine that public repo (davinci-github-actions) reuses actions from the private one (actions), why not vice-versa?

@sashuk
Copy link
Collaborator

sashuk commented Dec 1, 2023

@AlexDavidoiu Changesets needs to be added too, as this is a major change (the action is deleted and consumers can no longer rely on it)

@AlexDavidoiu AlexDavidoiu deleted the devx-3180 branch May 15, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants