Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI-2922] Update workflows to fetch secrets from GSM #240

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

serbantarmure
Copy link
Contributor

@serbantarmure serbantarmure commented Nov 21, 2023

CI-2922

Description

CI Infrastructure is reaching the final stage of migrating all GitHub Action secrets to centralized secrets management solution: Google Secrets Manager (here you can find the whole announcement). We create PRs in automatic way and the workflows are updated according to the documentation. Each workflow is different, so we should test them and make adjustments if necessary.

The changes will not influence performance of the workflow execution.

How to test

  • run workflow(s)

CI checklist:

  • all modified workflows were tested
  • check if the secrets were fetched from GSM correctly

Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: 1c06cf7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
davinci-github-actions Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@serbantarmure serbantarmure force-pushed the ci-fetch-secrets-from-gsm branch from 7da66c1 to 06e7215 Compare November 21, 2023 09:40
@serbantarmure serbantarmure marked this pull request as ready for review November 21, 2023 09:43
@serbantarmure serbantarmure requested a review from a team November 21, 2023 09:43
@serbantarmure serbantarmure self-assigned this Nov 21, 2023
@serbantarmure serbantarmure changed the title [CI] Update workflows to fetch secrets from GSM [CI-2922] Update workflows to fetch secrets from GSM Nov 21, 2023
@serbantarmure serbantarmure force-pushed the ci-fetch-secrets-from-gsm branch from 06e7215 to 1c06cf7 Compare November 21, 2023 10:04
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
@serbantarmure serbantarmure force-pushed the ci-fetch-secrets-from-gsm branch from 1af8745 to 1c06cf7 Compare November 22, 2023 10:55
@serbantarmure serbantarmure requested a review from a team November 22, 2023 10:55
@serbantarmure
Copy link
Contributor Author

@toptal-anvil ping reviewers

@serbantarmure
Copy link
Contributor Author

I've forced the run of the workflows and they were green

@github-actions github-actions bot added the contribution DO NOT ADD MANUALLY label Nov 22, 2023
@toptal-devbot
Copy link

Greetings from FX team, @serbantarmure 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

@serbantarmure serbantarmure force-pushed the ci-fetch-secrets-from-gsm branch from b736dc7 to 1c06cf7 Compare November 22, 2023 10:59
Copy link
Collaborator

@dmaklygin dmaklygin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the code. Looks solid

@serbantarmure serbantarmure merged commit 0541d45 into master Nov 23, 2023
9 checks passed
@serbantarmure serbantarmure deleted the ci-fetch-secrets-from-gsm branch November 23, 2023 08:41
@github-actions github-actions bot mentioned this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants