-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI-2922] Update workflows to fetch secrets from GSM #240
Conversation
🦋 Changeset detectedLatest commit: 1c06cf7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7da66c1
to
06e7215
Compare
06e7215
to
1c06cf7
Compare
1af8745
to
1c06cf7
Compare
@toptal-anvil ping reviewers |
I've forced the run of the workflows and they were green |
Greetings from FX team, @serbantarmure 👋 Thank you so much for contributing 🙇 We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme! What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉 🙏 please, help us improve, rate your contributing experience after merge |
b736dc7
to
1c06cf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the code. Looks solid
CI-2922
Description
CI Infrastructure is reaching the final stage of migrating all GitHub Action secrets to centralized secrets management solution: Google Secrets Manager (here you can find the whole announcement). We create PRs in automatic way and the workflows are updated according to the documentation. Each workflow is different, so we should test them and make adjustments if necessary.
The changes will not influence performance of the workflow execution.
How to test
CI checklist: