Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4380] Fix Storybook temploy link truncation #239

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

mkrl
Copy link
Contributor

@mkrl mkrl commented Nov 20, 2023

FX-4520

Description

Hostnames are actually truncated to 45 characters, not 63, acttording to our helm chart helpers.

How to test

  • FIXME: Add the steps describing how to verify your changes

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping FX team for review

@mkrl mkrl self-assigned this Nov 20, 2023
@mkrl mkrl requested a review from a team November 20, 2023 19:25
Copy link

changeset-bot bot commented Nov 20, 2023

🦋 Changeset detected

Latest commit: 32d9dcb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TomasSlama TomasSlama requested a review from a team November 21, 2023 08:02
@sashuk
Copy link
Collaborator

sashuk commented Nov 21, 2023

@mkrl Can you please provide guidelines on how to test it? Is it enough to run the temploy like in https://github.com/toptal/staff-portal/pull/11489#issuecomment-1816142681 and remove the postfix?

We need to check for other products like client-portal though.

Will this be done as part of this ticket?

@mkrl
Copy link
Contributor Author

mkrl commented Nov 21, 2023

@sashuk I'm checking with client and talent portal right now. I am not 100% confident it's safe to merge just yet. I think it might not be possible to test in staff-portal since this is an action that can be triggered only when it's on master.

@sashuk
Copy link
Collaborator

sashuk commented Nov 21, 2023

@mkrl Got it, thanks!

Copy link
Collaborator

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (assuming that tests in other portal will still be conducted)! @mkrl maybe we could test it with couple of force-merges in Staff Portal, I think it should be totally fine

@mkrl mkrl changed the title [FX-4380] Restore Storybook temploy link [FX-4380] Fix Storybook temploy link truncation Nov 22, 2023
@mkrl mkrl merged commit c8ea3b9 into master Nov 22, 2023
3 checks passed
@mkrl mkrl deleted the fx-4520-storybook-temploys-are-broken branch November 22, 2023 11:33
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants