Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle acl operations #311

Merged
merged 8 commits into from
Jan 2, 2025
Merged

feat: handle acl operations #311

merged 8 commits into from
Jan 2, 2025

Conversation

trungnotchung
Copy link
Contributor

@trungnotchung trungnotchung commented Dec 30, 2024 •
edited
Loading

@trungnotchung trungnotchung marked this pull request as draft December 30, 2024 14:22
@trungnotchung trungnotchung force-pushed the feat/handle-acl-operations branch from 818b306 to 4a71436 Compare December 31, 2024 03:55
@trungnotchung trungnotchung marked this pull request as ready for review December 31, 2024 04:14
@anhnd350309 anhnd350309 self-requested a review January 2, 2025 03:12
0xaldric

This comment was marked as spam.

Sign in to view

JanLewDev
JanLewDev approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@JanLewDev JanLewDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-roak d-roak self-requested a review January 2, 2025 14:57
d-roak
d-roak approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-roak d-roak merged commit 79133d0 into main Jan 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhnd350309 anhnd350309 anhnd350309 approved these changes

@0xaldric 0xaldric 0xaldric approved these changes

@JanLewDev JanLewDev JanLewDev approved these changes

@d-roak d-roak d-roak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proxyDRPHandler does not handle acl operations _computeState Fails for Nested Operation Types
5 participants
@trungnotchung @d-roak @JanLewDev @0xaldric @anhnd350309