Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add timestamp to vertex #288

Merged
merged 23 commits into from
Dec 29, 2024
Merged

feat: add timestamp to vertex #288

merged 23 commits into from
Dec 29, 2024

Conversation

magnified103
Copy link
Contributor

No description provided.

@d-roak d-roak requested a review from anhnd350309 December 17, 2024 07:26
@magnified103 magnified103 marked this pull request as ready for review December 18, 2024 06:46
JanLewDev

This comment was marked as outdated.

Sign in to view

@JanLewDev JanLewDev dismissed their stale review December 18, 2024 21:11

missclick

JanLewDev
JanLewDev reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@JanLewDev JanLewDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not differentiating between the first bootstrap sync and a later active sync?

trungnotchung
trungnotchung reviewed Dec 19, 2024
View reviewed changes
packages/object/src/hashgraph/index.ts Outdated Show resolved Hide resolved
packages/node/src/handlers.ts Outdated Show resolved Hide resolved
JanLewDev
JanLewDev approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@JanLewDev JanLewDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

trungnotchung
trungnotchung approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@trungnotchung trungnotchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

d-roak
d-roak reviewed Dec 29, 2024
View reviewed changes
Copy link
Member

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after both changes are applied, i'm good to merge it. If you still want to keep the discussion about clock precision. Let's continue it on discord

packages/object/src/hashgraph/index.ts Outdated Show resolved Hide resolved
packages/object/src/hashgraph/index.ts Show resolved Hide resolved
@d-roak
Copy link
Member

d-roak commented Dec 29, 2024

also seems there are a few conflicts, please fix those

@d-roak d-roak merged commit b2a0f38 into main Dec 29, 2024
12 checks passed
@magnified103 magnified103 deleted the feat/timestamp branch December 30, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungnotchung trungnotchung trungnotchung approved these changes

@JanLewDev JanLewDev JanLewDev approved these changes

@d-roak d-roak d-roak approved these changes

@anhnd350309 anhnd350309 Awaiting requested review from anhnd350309 anhnd350309 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magnified103 @d-roak @JanLewDev @trungnotchung