feat: add grid collision example #241
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwkang1998
requested review from
d-roak,
JanLewDev,
elielnfinic,
trungnotchung and
hoangquocvietuet
as code owners
|
Facing some issues running this and getting it working with local bootstrap node. Will mark as done once tested to be working on local. |
cwkang1998
force-pushed
the
feat/grid-collision
branch
2 times, most recently
from
1e3367f to
2d6dd9a
Compare
d-roak
removed request for
elielnfinic,
JanLewDev,
trungnotchung and
hoangquocvietuet
cwkang1998
force-pushed
the
feat/grid-collision
branch
from
2d6dd9a to
7cecc5e
Compare
Add a new example with grid 2d where collision is implemented. This utilizes the `resolveConflicts` CRO function for conflict resolution on the user position. This also reveals an issue with the `this` context within the `object` package when `resolveConflicts` is callback from `TopologyObject`.
cwkang1998
force-pushed
the
feat/grid-collision
branch
from
7cecc5e to
60ade98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new example with grid 2d where collision is implemented. This utilizes the
resolveConflictsCRO function for conflict resolution on the user position.This also reveals an issue with the
thiscontext within theobjectpackage whenresolveConflictsis callback fromTopologyObject. Opened an issue at #242.Closes #228