Albumname #1
Open
Albumname #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 19, 2023 15:46
martinverhey
approved these changes
Jul 24, 2023
Comment on lines
20
to
39
| guard let imageData = (arguments["imageBytes"] as? FlutterStandardTypedData)?.data, | ||
| let image = UIImage(data: imageData), | ||
| let quality = arguments["quality"] as? Int, | ||
| let albumName = arguments["albumName"] as? String, | ||
| let _ = arguments["name"], | ||
| let isReturnImagePath = arguments["isReturnImagePathOfIOS"] as? Bool | ||
| else { return } | ||
| let newImage = image.jpegData(compressionQuality: CGFloat(quality / 100))! | ||
| saveImage(UIImage(data: newImage) ?? image, isReturnImagePath: isReturnImagePath) | ||
| saveImage(image: UIImage(data: newImage) ?? image, albumName: albumName, isReturnImagePath: isReturnImagePath) | ||
| } else if (call.method == "saveFileToGallery") { | ||
| guard let arguments = call.arguments as? [String: Any], | ||
| let path = arguments["file"] as? String, | ||
| let albumName = arguments["albumName"] as? String, | ||
| let _ = arguments["name"], | ||
| let isReturnFilePath = arguments["isReturnPathOfIOS"] as? Bool else { return } | ||
| if (isImageFile(filename: path)) { | ||
| saveImageAtFileUrl(path, isReturnImagePath: isReturnFilePath) | ||
| saveImage(url: path, albumName: albumName, isReturnImagePath: isReturnFilePath) | ||
| } else { | ||
| if (UIVideoAtPathIsCompatibleWithSavedPhotosAlbum(path)) { | ||
| saveVideo(path, isReturnImagePath: isReturnFilePath) | ||
| saveVideo(path, albumName: albumName, isReturnImagePath: isReturnFilePath) |
There was a problem hiding this comment.
Je indentation staat niet goed. Of het is tabs vs spaces o.i.d.
Alleen als je het wilt insturen als echte PR zou ik er iets mee doen. Voor ons maakt het verder niet uit.
(We can re-indent selected code in Xcode by pressing Ctrl + I . To re-indent the whole file: Command + A then Ctrl + I)
martinverhey
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.