Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

fix: let extension ID be configured in manifest.json #431

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wkillerud
Copy link

Description

  • Makes extensionId optional.
  • Validates that ID is set either in manifest.json or in configuration for Semantic Release.

Fixes #418

Checklist

  • This PR has updated documentation
  • This PR has sufficient testing

DevQA

DevQA Prep

  • None

DevQA Steps

  • Regression test existing setup with extensionId.
  • Consider testing by setting the ID in manifest.json like in verifyConditions.test.js.

@ajyey
Copy link

ajyey commented Jun 24, 2024

Any chance we can get some eyes on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant pass extensionId validation
2 participants