feat(microsoft_store): Add Microsoft Store step for Windows #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rikiub
approved these changes
Oct 19, 2024
SteveLauC
approved these changes
Oct 20, 2024
SteveLauC
reviewed
Oct 22, 2024
locales/app.yml
Outdated
| "Microsoft Store": | ||
| en: "Microsoft Store" | ||
| es: "Tienda de Microsoft" | ||
| zh_TW: "Microsoft 店鋪" |
There was a problem hiding this comment.
Suggested change
| zh_TW: "Microsoft 店鋪" | |
| zh_TW: "Microsoft Store" |
Looks like "Microsoft Store" won't be translated:
text in the below picture: Microsoft Store Support
|
Just checked the zh_TW translations and left a comment, let's merge the PR once we have it resolved:) BTW, there is a conflict in |
Add Microsoft Store Apps update step for Windows as Winget cannot update all Microsoft Store apps yet. Closes topgrade-rs#912
|
Thanks @SteveLauC @olivertzeng, should be ready to merge now then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Microsoft Store Apps update step for Windows as Winget cannot update all Microsoft Store apps yet.
Closes #912.
What does this PR do
Adds a Microsoft Store Apps update step for Windows.
Standards checklist
CONTRIBUTING.mdFor new steps
--dry-runoption works with this step--yesoption works with this step if it is supported bythe underlying command
If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.
@Rikiub, could you verify the Spanish translations?
@olivertzeng, could you verify the Taiwanese translations?
Success
Error
Note that the '0' in output will be a number other than 0 when a real error occurs.