i18n(app.yml): new language zh_TW

[olivertzeng]

translated topgrade to zh_TW

What does this PR do

Standards checklist

• The PR title is descriptive.
• I have read CONTRIBUTING.md
• Optional: I have tested the code myself

For new steps

• Optional: Topgrade skips this step where needed
• Optional: The --dry-run option works with this step
• Optional: The --yes option works with this step if it is supported by
  the underlying command
  add i18n #2

Notes: the tests were successful but the locales doesn't show somehow

[SteveLauC]

Thanks for the PR, left some comments.

[SteveLauC]

CI is not running because we have conflicts.

[olivertzeng]

@SteveLauC I suggest having po and mo files or such that separates different languages

That way translating will be much much easier

[olivertzeng]

CI is not running because we have conflicts.

Will solve this tonight

[SteveLauC]

I suggest having po and mo files or such that separates different languages

Interesting, TIL, I agree, though I am not sure if the i18n library used by Topgrade is capable of coping with this. 🤔

[SteveLauC]

LGTM, thanks for the patch!

[Mastermindaxe]

I suggest having po and mo files or such that separates different languages

Interesting, TIL, I agree, though I am not sure if the i18n library used by Topgrade is capable of coping with this. 🤔

@SteveLauC
We could have different files for each language. But is it really better to have them separated? When everything is in one file you can see immediately if there is a key missing for a language you're implementing. On the other hand you'd probably just copy over the english translation file and fill that out step-by-step 🤔 I'd be okay with both. The framework certainly supports it if I recall correctly

[SteveLauC]

When everything is in one file you can see immediately if there is a key missing for a language you're implementing. On the other hand you'd probably just copy over the english translation file and fill that out step-by-step

Yeah, putting translations together will make adding new language support and checking easier. Let's keep the current
approach.