Skip to content

Commit

Permalink
TODO -> FIXME
Browse files Browse the repository at this point in the history
Or just delete

Closes rust-lang#25
  • Loading branch information
nrc committed Jun 22, 2018
1 parent 5c1884e commit 87edd75
Show file tree
Hide file tree
Showing 8 changed files with 5 additions and 11 deletions.
2 changes: 0 additions & 2 deletions src/filemap.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// TODO: add tests

use std::fs;
use std::io::{self, Write};

Expand Down
2 changes: 1 addition & 1 deletion src/format-diff/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ where
None => continue,
};

// TODO(emilio): We could avoid this most of the time if needed, but
// FIXME(emilio): We could avoid this most of the time if needed, but
// it's not clear it's worth it.
if !file_filter.is_match(file) {
continue;
Expand Down
4 changes: 2 additions & 2 deletions src/items.rs
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ impl Rewrite for ast::Local {
}
}

// TODO convert to using rewrite style rather than visitor
// TODO format modules in this style
// FIXME convert to using rewrite style rather than visitor
// FIXME format modules in this style
#[allow(dead_code)]
struct Item<'a> {
keyword: &'static str,
Expand Down
1 change: 0 additions & 1 deletion src/lists.rs
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ where
}

// Format a list of commented items into a string.
// TODO: add unit tests
pub fn write_list<I, T>(items: I, formatting: &ListFormatting) -> Option<String>
where
I: IntoIterator<Item = T> + Clone,
Expand Down
1 change: 0 additions & 1 deletion src/macros.rs
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ pub fn rewrite_macro_inner(
};
}
// Format well-known macros which cannot be parsed as a valid AST.
// TODO: Maybe add more macros?
if macro_name == "lazy_static!" && !has_comment {
if let success @ Some(..) = format_lazy_static(context, shape, &ts) {
return success;
Expand Down
2 changes: 0 additions & 2 deletions src/missed_spans.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ impl<'a> FmtVisitor<'a> {
self.buffer.is_empty()
}

// TODO these format_missing methods are ugly. Refactor and add unit tests
// for the central whitespace stripping loop.
pub fn format_missing(&mut self, end: BytePos) {
// HACK(topecongiro)
// We use `format_missing()` to extract a missing comment between a macro
Expand Down
2 changes: 1 addition & 1 deletion src/reorder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
//! order. Trait items are reordered in pre-determined order (associated types
//! and constants comes before methods).
// TODO(#2455): Reorder trait items.
// FIXME(#2455): Reorder trait items.

use config::{lists::*, Config};
use syntax::{ast, attr, codemap::Span};
Expand Down
2 changes: 1 addition & 1 deletion src/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ fn type_bound_colon(context: &RewriteContext) -> &'static str {

impl Rewrite for ast::WherePredicate {
fn rewrite(&self, context: &RewriteContext, shape: Shape) -> Option<String> {
// TODO: dead spans?
// FIXME: dead spans?
let result = match *self {
ast::WherePredicate::BoundPredicate(ast::WhereBoundPredicate {
ref bound_generic_params,
Expand Down

0 comments on commit 87edd75

Please sign in to comment.