Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End Improvements #759

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

burgerindividual
Copy link
Contributor

@burgerindividual burgerindividual commented May 16, 2020

Fixes #234 and fixes #116

This doesn't add the outer end gateways that are generated when you throw an ender pearl into a gateway on the main island. Those were going to be hard to do and it was pretty unrealistic. This does include the ones on the islands and the ones randomly generated around the end.

EDIT: I don't know why I thought the outer gateways were going to be so hard, but I don't think they actually will. I'll mark this as a draft and add it when I have the chance.

EDIT 2: The outer gateways were actually really hard, but I got it to mostly work.

@burgerindividual burgerindividual marked this pull request as draft May 16, 2020 18:32
@burgerindividual
Copy link
Contributor Author

I got the outer ring gateways to show an approximate location of where they will generate. Usually they end up ~40 blocks away from where they actually are, but we can't really do anything about that. It does take a few seconds to generate the cache, but afterwards it doesn't cause any slowdowns.

I also fixed the cursor information for biomes in the end. They now show the correct biomes instead of just one.

@burgerindividual burgerindividual marked this pull request as ready for review May 23, 2020 00:00
@geraintwhite
Copy link

Looks like the tests are failing at Running amidst.mojangapi.world.test.TestWorldEntryEquality.

@geraintwhite
Copy link

@Burgerguy I tested this on v4.5-beta1 and it works perfectly.

@burgerindividual
Copy link
Contributor Author

@grit96 I'm still working on some other changes to the end at the moment, so I'll mark this PR as a draft. Also with the tests, I'm not sure what's causing them even after looking through them.

@burgerindividual burgerindividual marked this pull request as draft June 29, 2020 00:55
@burgerindividual burgerindividual marked this pull request as ready for review July 1, 2020 03:57
@burgerindividual
Copy link
Contributor Author

I marked this PR as ready for review after fixing up a few things. First, the stuff that was already there was updated to work with 1.16. Second, I added the small end islands starting from 1.13. While it is true that it wasn't possible to procedurally generate the small end islands from the seed alone, 1.13 allowed that to be possible.

Screenshot:
image

@burgerindividual burgerindividual changed the title Add End Gateways and speed up some things in EndIslandOracle End Improvements Jul 1, 2020
@burgerindividual
Copy link
Contributor Author

@moulins This PR should be ready for merging. It's up to date with master and includes everything that's needed.

@burgerindividual
Copy link
Contributor Author

I figured out why the tests weren't working. Due to the refactoring of the end islands, I had to make some changes to the TestWorldEntryEquality test. It still tests the large islands only, so maybe at some point that could be changed to work with the small islands too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.11 "Escape portals" Map the End gateway portals, if possible
2 participants