Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome Version 115.0.5790.102 seems to have broken positioning #52

Closed
KalliMan opened this issue Jul 25, 2023 · 23 comments
Closed

Chrome Version 115.0.5790.102 seems to have broken positioning #52

KalliMan opened this issue Jul 25, 2023 · 23 comments

Comments

@KalliMan
Copy link

After upgrade to the latest chrome, the popper positionning does not work correctly enymore.

The easiest way to reproduce the problem is using the supplied examples:
https://tonysamperi.github.io/ngx-popperjs/

It is reproducible at least on " OVERFLOW PREVENTION", "OPEN ON CLICK", "OPEN ON CLICK + CLOSE ON SCROLL" examples. What is interesting that scrolling fixes the position of the popper.

Note: The same issue is reported for the ngx-popper:
MrFrankel/ngx-popper#180

@tonysamperi
Copy link
Owner

tonysamperi commented Jul 26, 2023

I'm removing a few comments with weird CSS solutions, because mostly they don't work at all.
I'm working at the fix but it's not simple.

@muneeb26
Copy link

muneeb26 commented Aug 1, 2023

Hey @tonysamperi do you know when there will an official fix released for this?

@tonysamperi
Copy link
Owner

@muneeb26 hi, I should be able to release something at least for v16 this week!

@AdamsContreras999
Copy link

great Mr we would be grateful for this solution @tonysamperi

@tonysamperi
Copy link
Owner

tonysamperi commented Aug 2, 2023

@serhiisol this is what I'm talking about. If it's not visible (opacity) but not hidden (block) you won't be able to click "My action".
Also in this specific scenario, a part of the popper covers the trigger, so if I click there, the popper won't show!

image

@tonysamperi
Copy link
Owner

Yeah, but that I don't like as well, because in a first instance the popper is shown somewhere and when you recalculate it moves...
I think I got the right solution though...
Keep you posted

@tonysamperi
Copy link
Owner

It shouldn't be a problem for the case if appendTo set to body. @tonysamperi do you need help with the solution?

No, don't worry I'll figure this out.
Btw in v17 I could be migrating to the new floating UI lib...

Cheers

Repository owner deleted a comment from gertot Aug 2, 2023
Repository owner deleted a comment from KalliMan Aug 2, 2023
Repository owner deleted a comment from gertot Aug 2, 2023
Repository owner deleted a comment from serhiisol Aug 2, 2023
Repository owner deleted a comment from serhiisol Aug 2, 2023
Repository owner deleted a comment from serhiisol Aug 2, 2023
tonysamperi added a commit that referenced this issue Aug 2, 2023
* Fixed position issues if shown on click + hover w/ Chrome 115.0.5790.102 (closes [#52](#52))
@zanaBizz
Copy link

zanaBizz commented Aug 3, 2023

@tonysamperi Is the fix also going to be backported to v15 for users who haven't yet migrated to using Angular v16?

@tonysamperi
Copy link
Owner

tonysamperi commented Aug 3, 2023

@zanaBizz yes. I was waiting to see if it was stable on v16. Right choice, since there was a teeny tiny bug.
Should publish v15 and v14 and v13 in a few hours...I'm also going to check how many usages of v12 still there...

tonysamperi added a commit that referenced this issue Aug 3, 2023
* Fixed position issues if shown on click + hover w/ Chrome 115.0.5790.102 (closes [#52](#52))
tonysamperi added a commit that referenced this issue Aug 3, 2023
* Fixed position issues if shown on click + hover w/ Chrome 115.0.5790.102 (closes [#52](#52))
* Fixed hide on scroll
@YevheniiPuzyrenko
Copy link

Hi, @tonysamperi !
is the fix gonna be ported to v13 also ?

@tonysamperi
Copy link
Owner

Hi, @tonysamperi ! is the fix gonna be ported to v13 also ?

Yes! Later today!

@serhiiuq
Copy link

serhiiuq commented Aug 7, 2023

The issue also happens when popperAppendTo="body" is specified on the first event. Note: happens with the latest update.

@tonysamperi
Copy link
Owner

tonysamperi commented Aug 7, 2023

Ok everybody. I figured the real fix. I was so close, but I didn't consider I needed to skip a frame.
I'm reverting to the 16.0.1 and applying the real fix (with v 16.0.6 and of course the v 15 14 and 13)

Thanks @solo-unitq because I got that to fix the "append to body".

@tonysamperi tonysamperi reopened this Aug 7, 2023
@AdamsContreras999
Copy link

Bien, todos. Me di cuenta de la solución real. Estaba tan cerca, pero no consideré que necesitaba saltarme un cuadro. Estoy volviendo a la versión 16.0.1 y aplicando la solución real (con la versión 16.0.6 y, por supuesto, la versión 15, 14 y 13)

Gracias@solo-unitqporque obtuve eso para arreglar el "agregar al cuerpo".

please man ! awesome!

@kundralaci
Copy link

Ok everybody. I figured the real fix. I was so close, but I didn't consider I needed to skip a frame. I'm reverting to the 16.0.1 and applying the real fix (with v 16.0.6 and of course the v 15 14 and 13)

Thanks @solo-unitq because I got that to fix the "append to body".

Thank you very much for hunting down this bug! Can you please also port it back to the 12 version? (Yes, I know we really need to update, but it's not my decision, unfortunately... thank you again!)

@EdoMagen
Copy link

EdoMagen commented Aug 8, 2023

Thank you @tonysamperi !

@tonysamperi
Copy link
Owner

Hi all, released the new versions for v16, 15 and 14. Tomorrow 13 and 12.

Repository owner deleted a comment from AdamsContreras999 Aug 9, 2023
Repository owner deleted a comment from AdamsContreras999 Aug 9, 2023
@tonysamperi
Copy link
Owner

Released v 13 and 12!

@aleksander351
Copy link

It shouldn't be a problem for the case if appendTo set to body. @tonysamperi do you need help with the solution?

No, don't worry I'll figure this out. Btw in v17 I could be migrating to the new floating UI lib...

Cheers

@tonysamperi
After updating to the latest version, sometimes the vertical position is still not calculated correctly. It occurs on Edge as well as on Chrome browsers.
I.e. the y value after the first click is 397, whereas on the second try it's 257, which is correct.

position-1
position-3

@tonysamperi
Copy link
Owner

@aleksander351 please create a blitz reproducing the problem and report all the info, including OS, RAM, etc.

@ahmedataulkareem
Copy link

ahmedataulkareem commented Oct 9, 2023

I am facing the same issue as @aleksander351. It renders the pop-up correctly but sometimes doesn't calculate the vertical length properly which results in rendering the pop-up at the wrong place. Facing this issue with Angular v14 and ngx-popperjs v14.1.8

image
image

Added the s.s for the following when the error reoccurs

@tonysamperi
Copy link
Owner

@ahmedataulkareem man, same reply as aleksander...please create a blitz!

@aleksander351
Copy link

aleksander351 commented Oct 10, 2023

@ahmedataulkareem man, same reply as aleksander...please create a blitz!

we solved it with the position: unset; workaround for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests