Message actions not properly visible

[szuperaz]

This is caused by an underlying issue in a lib that we use: tonysamperi/ngx-popperjs#52

This also affects

• hover info for reactions
• hover info for message status

[szuperaz]

Quick fix is available in [email protected]

[andreas-myklebust]

Hi Zita, thank you for the quick fix, we were running into a lot of this issue as well 👍 But unfortunately after upgrading from 4.28.0 to 4.32.1 we started having other issues and bugs connected to templates, that we didn't have before. A ton of "RangeError: Maximum call stack size exceeded" errors

Has this been reported already? If so, do you know what could be the issue? Thanks!

[szuperaz]

Hi,

It hasn't been reported before, I've tested with our customizations example app that has a lot of ng templates, but I couldn't reproduce the bug.

Please try if version 4.30.0 works for you. Because it might be those changes that could cause the problems. Are these errors present for all of your custom templates or just some? If for just some, can you please specify which ones?

[andreas-myklebust]

Hi, the Call Stack errors are not present on 4.30.0, but the Message actions are naturally then broken as the fix for it is not before 4.32.1.

For the call stack issues, it seems to be happening on all of our Attachment templates at least.. Namely customFileAttachment, customImageAttachment, customGalleryAttachment and customVideoAttachment, in our case.

NOTE: I can only reproduce this on our mobile (Emulated, in the browser) version, though it uses the same code for implementing the templates. Hope that helps

[szuperaz]

I've created a test app with custom attachments and message actions on this branch: https://github.com/GetStream/stream-chat-angular/tree/call-stack-reproduction, and ran it in Google Chrome inside an Android emulator (see attached video) but unfortunately, I was unable to reproduce it.

Please try and reproduce the problem in the linked sample app (how to run).

Screen.Recording.2023-08-08.at.13.54.56.mov

[andreas-myklebust]

I went over and confirmed on our app the change happened from 4.29.1-4.30.0, however I'm not sure if it's due to a special implementation on our side, I just downloaded the demo you made, but I don't have a user to test, without involving server side to get a user, do you have any test users with messages that could be used instead? Thanks

[andreas-myklebust]

Here is also an example of where it happened to a very simple change, but somehow with the changes in 4.30.0, it is broken, note the emulator renderer, not sure if it is helpful

[szuperaz]

I've updated the reproduction app

• To use one of our demo app to authenticate
• Added a custom avatar template as well

[andreas-myklebust]

On the callstack issues, one of our devs found a workaround a while back, might have been patched in a new version of the SDK.

On the note of the issues with the Message Actions, I was wondering if this issue includes the actions menu being cut off?

[szuperaz]

I think this was a side effect of the quick fix, [email protected] contains the official fix for the library that we use for the menu position, let me know if you still experience this problem with [email protected]

[andreas-myklebust]

@szuperaz Thank you for letting me know, the issue where it gets cut off seems to have been fixed from what I can see, I'm sending it to the testers to confirm 👍 But can be considered solved for now from my side at least. Thank you again!

[szuperaz]

Thanks for the quick reply, I'll close the issue, but feel free to reopen it if the problem returns.