Implement fan control behind feature flag #29
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going red because it depends on tonarino/panel-protocol#14
Adds a feature flag that allows controlling fans and completely disables controlling lights, so that conflict isn't possible. Commands parsed for the unavailable feature are just ignored.
Untested, would be good to test with actual fans :).
Note that this preserves previous behaviour: the PWM are initialized at 0, which is inverted into a max duty cycle and means the fans start at max speed until set otherwise.