Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headless sharing and X11 screen id on 0.29.1 #1

Open
wants to merge 2 commits into
base: 0.29.x
Choose a base branch
from

Conversation

strohel
Copy link
Member

@strohel strohel commented Oct 8, 2023

PR just for documentation of patches used. Relates to https://github.com/tonarino/portal/pull/2741

@strohel strohel changed the title Headless sharing x11 screen id on 0.29.1 Headless sharing and X11 screen id on 0.29.1 Oct 8, 2023
@mbernat
Copy link

mbernat commented Apr 10, 2024

glutin 0.31 has removed most windowing code (which should now be provided by other libraries instead), so this PR might not be necessary anymore, once we upgrade.

  • The only usage of initWithFormat_shareContext seems to be during context creation and it uses the provided shared context (see code).
  • As mentioned on the winit fork, screen_id should now be handled by the new versions of winit and raw-window-handle crates, so might just work now without doing anything in glutin.

Remains to be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants