This repository has been archived by the owner on Dec 22, 2018. It is now read-only.
#14 - All specs video path #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 23, 2017 11:35
… case, when one video file is produced. Added a new option called allSpecsVideoName which can be either a string or a function. It is combined with the baseDirectory option to create a full path.
|
Hi Jean
I think that's it. |
yeikel
reviewed
Apr 16, 2018
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "protractor-video-reporter", | |||
| "version": "0.3.0", | |||
| "version": "0.3.1", | |||
There was a problem hiding this comment.
As stated, please do not change version numbers in a regular PR. Version number should be changed when we do a release
|
@tomyam1 Is this PR dead? Last activity was way back |
thomsavage
reviewed
Jun 12, 2018
| @@ -56,6 +56,20 @@ For example, you can do: | |||
| result.fullName + '.mov'; | |||
| } | |||
|
|
|||
|
|
|||
| * `allSpecsVideoName`: (function): | |||
There was a problem hiding this comment.
Since both singleVideo === true and baseDirectory required by default, maybe this should be called defaultVideoName?
|
|
||
| For example, you can do: | ||
|
|
||
| allSpecsVideoName: function (result) { |
There was a problem hiding this comment.
The result argument here isn't actually passed to the user function in the implementation. Fix impl or remove the false doc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14 - Allow specifying other name than protractor-specs.mov in case, when one video file is produced.
Added a new option called allSpecsVideoName which can be either a string or a function. It is combined with the baseDirectory option to create a full path.