Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(Refactor and adding support for future release): #408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature(Refactor and adding support for future release): #408

wants to merge 1 commit into from

Conversation

PipesNBottles
Copy link
Contributor

@PipesNBottles PipesNBottles commented Jul 23, 2024 •
edited by tomquirk
Loading

  • adds query options to make it easier to distinguish what can be searched for
  • adds abstract class for inheritance later on for linkedin class
  • moves imports around for errors and settings
  • changes from pipfile to poetry for development
  • adds api builder class to isolate the api and param passing
  • adds schemas for responses from linkedin allowing objects and type checking in the future
  • adds future libraries for 3.8 release

RElated: #432

@PipesNBottles
feature(Refactor and adding support for future release):
a4bbdce 
- adds query options to make it easier to distinguish what can be searched for
- adds abstract class for inheritance later on for linkedin class
- moves imports around for errors and settings
- changes from pipfile to poetry for development
- adds api builder class to isolate the api and param passing
- adds schemas for responses from linkedin allowing objects and type checking in the future
- adds future libraries for 3.8 release
@tomquirk
Copy link
Owner

Hey @PipesNBottles , thank you for this! Will take me a bit to review this one. Hopefully I can get to it soon 🙏

@PipesNBottles
Copy link
Contributor Author

Hey @PipesNBottles , thank you for this! Will take me a bit to review this one. Hopefully I can get to it soon 🙏

Not a problem, take your time. If you find any issues I'll respond here

@tomquirk
Copy link
Owner

Hey @PipesNBottles , just a quick one to say that I haven't forgotten about this! I think we'll want to pull some of your ideas into master in a piece-meal fashion. I'll probably pick out various parts of this and merge separately (and add you as commit co-author for attribution, of course).

@tomquirk tomquirk self-requested a review August 26, 2024 22:23
@tomquirk tomquirk self-assigned this Aug 27, 2024
@tomquirk
Copy link
Owner

tomquirk commented Sep 1, 2024

Poetry migration is in 🫡 #423

@tomquirk
Copy link
Owner

Related: #432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomquirk tomquirk Awaiting requested review from tomquirk

At least 1 approving review is required to merge this pull request.

Assignees

@tomquirk tomquirk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PipesNBottles @tomquirk