Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide extra markers displayed in Safari. #185

Merged
merged 2 commits into from
Aug 17, 2024
Merged

Hide extra markers displayed in Safari. #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a275eb9
Hide extra markers displayed in `Safari`.
CoralPink May 27, 2024
54d27fc
[review] move webkit fix
tommilligan Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions compile_assets/scss/admonition.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,12 @@ summary.admonition-title {
details[open].admonition > &::after {
transform: rotate(90deg);
}

// Hide details marker for Safari that loves to show it anyway
// ref: https://github.com/tommilligan/mdbook-admonish/pull/185
&::-webkit-details-marker {
display: none;
}
}

:root {
Expand Down
2 changes: 1 addition & 1 deletion integration/book.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ title = "mdbook-admonish-integration"

[preprocessor.admonish]
command = "mdbook-admonish"
assets_version = "3.0.2" # do not edit: managed by `mdbook-admonish install`
assets_version = "3.0.3" # do not edit: managed by `mdbook-admonish install`
after = ["links"]

[[preprocessor.admonish.custom]]
Expand Down
2 changes: 1 addition & 1 deletion integration/expected/book.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ title = "mdbook-admonish-integration"

[preprocessor.admonish]
command = "mdbook-admonish"
assets_version = "3.0.2" # do not edit: managed by `mdbook-admonish install`
assets_version = "3.0.3" # do not edit: managed by `mdbook-admonish install`
after = ["links"]

[[preprocessor.admonish.custom]]
Expand Down
2 changes: 1 addition & 1 deletion src/bin/assets/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0.2
3.0.3
3 changes: 3 additions & 0 deletions src/bin/assets/mdbook-admonish.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ details.admonition > summary.admonition-title::after {
details[open].admonition > summary.admonition-title::after {
transform: rotate(90deg);
}
summary.admonition-title::-webkit-details-marker {
display: none;
}

:root {
--md-details-icon: url("data:image/svg+xml;charset=utf-8,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24'><path d='M8.59 16.58 13.17 12 8.59 7.41 10 6l6 6-6 6-1.41-1.42Z'/></svg>");
Expand Down