fix: support toml values with equal sign #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommilligan
force-pushed
the
fix-breaking-on-equals-in-value
branch
from
0581803 to
ffb819c
Compare
s00500
reviewed
May 29, 2024
| return Err(format!("TOML parsing error: {error}")); | ||
| } | ||
| }; | ||
| let mut config = user_input_from_config_toml(dbg!(config_toml))?; |
There was a problem hiding this comment.
Hey @tommilligan, seems like this line now causes quite some prints during the build that are not really relevant. Very minor issue, but maybe that was not intended ?
Looks like this:
.cargo/registry/src/index.crates.io-6f17d22bba15001f/mdbook-admonish-1.17.0/src/config/v2.rs:63:58] config_toml = "collapsible=true \ntitle=\"Display value (without control)\""
There was a problem hiding this comment.
Thanks, yes this was indeed unintentional. Opened #186 to resolve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #179
The v2 config format is not suitable for parsing complex toml values, specifically containing
=values. This is due to the pre-parsing wrangling to marshal key-value pairs into a valid TOML format using=as a marker for TOML keys, when in fact it can appear in values too.To fix this, introduce the new v3 config format which uses the TOML Inline Table syntax to support this natively.
This PR adds the config back-compatibly, falling back to v2 (and v1) if parsing with the new format fails. It also updates all docs/examples to use the new comma separated format where appropriate.